Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Replace uuid package with native crypto.randomUUID #1202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[no-Jira] Replace uuid package with native crypto.randomUUID #1202

wants to merge 2 commits into from

Conversation

canac
Copy link
Contributor

@canac canac commented Nov 18, 2024

Description

Replace the uuid package with the native crypto.randomUUID() method.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac added the Preview Environment Add this label to create an Amplify Preview label Nov 18, 2024
@canac canac self-assigned this Nov 18, 2024
@github-actions GitHub Actions
Copy link

Preview branch generated at https://native-uuid.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against e5e950c

No significant changes found

@canac
Copy link
Contributor Author

canac commented Nov 19, 2024

This will need to wait for node 20. In node 18 crypto isn't a global, it has to be imported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@canac canac

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@canac